RFR: 8353129: CDS ArchiveRelocation tests fail after JDK-8325132 [v2]
Calvin Cheung
ccheung at openjdk.org
Tue Apr 1 15:03:11 UTC 2025
On Tue, 1 Apr 2025 05:20:45 GMT, David Holmes <dholmes at openjdk.org> wrote:
> LGTM2. I hope it now passes tier4.
Yes, I re-ran tiers 1, 3, and 4 testing with the latest change.
> src/hotspot/share/prims/whitebox.cpp line 2136:
>
>> 2134: WB_ENTRY(jint, WB_GetArchiveRelocationMode(JNIEnv* env, jobject wb))
>> 2135: #if INCLUDE_CDS
>> 2136: return (jint)ArchiveRelocationMode;
>
> Nit: do we need casts between int and jint ??
The latest change doesn't involve whitebox.cpp.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24308#issuecomment-2769663183
PR Review Comment: https://git.openjdk.org/jdk/pull/24308#discussion_r2023041268
More information about the hotspot-dev
mailing list