RFR: 8353365: TOUCH_ASSERT_POISON clears GetLastError()

David Holmes dholmes at openjdk.org
Fri Apr 4 05:52:57 UTC 2025


This is a very simple fix to save/restore the "last error" value on Windows, so that the TOUCH_ASSERT_POISON mechanism used in assert/guarantee/fatal, does not clear it.

Testing
 - new Windows-only gtest added to vmErrors test group
 - tiers 103 sanity

Thanks.

-------------

Commit messages:
 - gtest - was easier to create than I had expected
 - 8353365: TOUCH_ASSERT_POISON clears GetLastError()

Changes: https://git.openjdk.org/jdk/pull/24435/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24435&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8353365
  Stats: 12 lines in 2 files changed: 12 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/24435.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24435/head:pull/24435

PR: https://git.openjdk.org/jdk/pull/24435


More information about the hotspot-dev mailing list