RFR: 8353365: TOUCH_ASSERT_POISON clears GetLastError()

Julian Waters jwaters at openjdk.org
Fri Apr 4 07:36:54 UTC 2025


On Fri, 4 Apr 2025 05:43:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

> This is a very simple fix to save/restore the "last error" value on Windows, so that the TOUCH_ASSERT_POISON mechanism used in assert/guarantee/fatal, does not clear it.
> 
> Testing
>  - new Windows-only gtest added to vmErrors test group
>  - tiers 103 sanity
> 
> Thanks.

Simple enough for me to review, so I'll give it a +1, just one trivial question

-------------

Marked as reviewed by jwaters (Committer).

PR Review: https://git.openjdk.org/jdk/pull/24435#pullrequestreview-2742091778


More information about the hotspot-dev mailing list