RFR: 8353365: TOUCH_ASSERT_POISON clears GetLastError()

Fri Apr 4 07:41:53 UTC 2025

On Fri, 4 Apr 2025 06:19:58 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Oh, sorry for that. Thanks @stefank @dholmes-ora for finding and fixing this. The patch is fine.
> 
> I wonder whether we have the same problem on Posix with errno, but I assume we don't call any functions there that modify errno.

Same problem exists for posix, but we already preserve errno:
https://github.com/openjdk/jdk/blob/41d4a0d7bdda2a96af1e7f549c05d99d68c040dc/src/hotspot/os/posix/signals_posix.cpp#L564-L566
That behavior goes back to https://bugs.openjdk.org/browse/JDK-6749267, fixed in jdk8.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24435#issuecomment-2777827385