RFR: 8353189: [ASAN] memory leak after 8352184 [v2]
SendaoYan
syan at openjdk.org
Tue Apr 8 03:55:05 UTC 2025
On Tue, 8 Apr 2025 02:58:49 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Use static static string instead of assemble string dynamic
>> - Revert "8353189: [ASAN] memory leak after 8352184"
>>
>> This reverts commit 71bc3ad34ebd57cc6642dfede18cec65e3694dd1.
>
> src/hotspot/share/runtime/abstract_vm_version.cpp line 140:
>
>> 138:
>> 139:
>> 140: const char* Abstract_VM_Version::vm_info_string() {
>
> For future benefit, how about also adding a comment explain why we avoid dynamic memory allocation for the vm_info_string here?
I have add a comment, but my English is not very well. If you have proper description, please let me known.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24299#discussion_r2032332152
More information about the hotspot-dev
mailing list