RFR: 8353189: [ASAN] memory leak after 8352184 [v2]

Jiangli Zhou jiangli at openjdk.org
Tue Apr 8 20:40:12 UTC 2025


On Tue, 8 Apr 2025 03:50:14 GMT, SendaoYan <syan at openjdk.org> wrote:

>> src/hotspot/share/runtime/abstract_vm_version.cpp line 140:
>> 
>>> 138: 
>>> 139: 
>>> 140: const char* Abstract_VM_Version::vm_info_string() {
>> 
>> For future benefit, how about also adding a comment explain why we avoid dynamic memory allocation for the vm_info_string here?
>
> I have add a comment, but my English is not very well. If you have proper description, please let me known.

Looks ok to me, thanks. Please update the contributor properly since the change is from https://github.com/openjdk/jdk/pull/24171/commits/baff6b166d130c9adeecfb9f2b418d86322d4826.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24299#discussion_r2033982904


More information about the hotspot-dev mailing list