RFR: 8353175: Eliminate double iteration of stream in FieldDescriptor reinitialization [v6]

[Aleksey Shipilev]

On Thu, 10 Apr 2025 11:58:09 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> I know you haven't asked specifically for iterators, but to me this seems 'the' cleaner way, rather than plain old indexed loop. Or do you have doubts about this being inlined to effectively the same code?
>
> I think using an iterator is fine, that's up to you. I am a bit bothered by having this change also slip in a change to the `GrowableArray` API, however. Anyone who wants to review that part of the code will miss that change.
> 
> I'd like to suggest that you change to an indexed for loop, and you make a follow-up PR with your GA changes and where you switch the loop.

Yeah, it is not about cleanliness, but rather about doing one (good) thing at a time.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24290#discussion_r2037189271