RFR: 8353175: Eliminate double iteration of stream in FieldDescriptor reinitialization [v6]
Radim Vansa
rvansa at openjdk.org
Thu Apr 10 14:16:36 UTC 2025
On Thu, 10 Apr 2025 12:04:31 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> I think using an iterator is fine, that's up to you. I am a bit bothered by having this change also slip in a change to the `GrowableArray` API, however. Anyone who wants to review that part of the code will miss that change.
>>
>> I'd like to suggest that you change to an indexed for loop, and you make a follow-up PR with your GA changes and where you switch the loop.
>
> Yeah, it is not about cleanliness, but rather about doing one (good) thing at a time.
OK, reverted to indexed loop.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24290#discussion_r2037529823
More information about the hotspot-dev
mailing list