RFR: 8351162: Clean up x86 (Macro)Assembler after 32-bit x86 removal
Vladimir Kozlov
kvn at openjdk.org
Tue Apr 15 17:32:48 UTC 2025
On Mon, 14 Apr 2025 18:47:56 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> This improvement targets x86 `(Macro)Assembler`. We are mostly cleaning up `LP64` predicated code blocks, and a bit of related code.
>
> It is enticing to remove all `*ptr` methods, and rename all uses from `*ptr` to `*q`, but that turns out to be very intrusive. That is left for a future RFE, if we ever consider doing it.
>
> Additional testing:
> - [x] Linux x86_64 server fastdebug, `all`
src/hotspot/cpu/x86/assembler_x86.inline.hpp line 32:
> 30: #include "code/codeCache.hpp"
> 31:
> 32: // TODO: Remove?
Yes, remove. There are no files which include it anymore.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24631#discussion_r2045135239
More information about the hotspot-dev
mailing list