RFR: 8351162: Clean up x86 (Macro)Assembler after 32-bit x86 removal

[Aleksey Shipilev]

On Tue, 15 Apr 2025 17:30:01 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> This improvement targets x86 `(Macro)Assembler`. We are mostly cleaning up `LP64` predicated code blocks, and a bit of related code.
>> 
>> It is enticing to remove all `*ptr` methods, and rename all uses from `*ptr` to `*q`, but that turns out to be very intrusive. That is left for a future RFE, if we ever consider doing it.
>> 
>> Additional testing:
>>  - [x] Linux x86_64 server fastdebug, `all`
>
> src/hotspot/cpu/x86/assembler_x86.inline.hpp line 32:
> 
>> 30: #include "code/codeCache.hpp"
>> 31: 
>> 32: // TODO: Remove?
> 
> Yes, remove. There are no files which include it anymore.

Ah no, here is the use:


/home/shade/trunks/jdk/src/hotspot/share/asm/assembler.inline.hpp:30:1: fatal error: assembler_x86.inline.hpp: No such file or directory
   30 | #include CPU_HEADER_INLINE(assembler)
      | ^~~~~~~~~~~~~


And we have to leave this, as some platforms do have non-empty `.inline.hpp`-s. I'll just remove the TODO.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24631#discussion_r2045176369