RFR: 8351162: Clean up x86 (Macro)Assembler after 32-bit x86 removal [v2]

Aleksey Shipilev shade at openjdk.org
Tue Apr 15 18:30:26 UTC 2025


On Tue, 15 Apr 2025 17:55:40 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/cpu/x86/assembler_x86.inline.hpp line 32:
>> 
>>> 30: #include "code/codeCache.hpp"
>>> 31: 
>>> 32: // TODO: Remove?
>> 
>> Yes, remove. There are no files which include it anymore.
>
> Ah no, here is the use:
> 
> 
> /home/shade/trunks/jdk/src/hotspot/share/asm/assembler.inline.hpp:30:1: fatal error: assembler_x86.inline.hpp: No such file or directory
>    30 | #include CPU_HEADER_INLINE(assembler)
>       | ^~~~~~~~~~~~~
> 
> 
> And we have to leave this, as some platforms do have non-empty `.inline.hpp`-s. I'll just remove the TODO.

Also transitive includes, grr. I pushed new commit that should handle all of this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24631#discussion_r2045223484


More information about the hotspot-dev mailing list