RFR: 8354558: -XX:AOTMode=record crashes with boot loader package-info class

[Calvin Cheung]

On Thu, 17 Apr 2025 04:26:40 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> When a package is loaded from `-Xbootclasspath/a:`, its `package-info` class is loaded by a special loader of the type `jdk/internal/loader/ClassLoaders$BootClassLoader`. The AOT cache doesn't handle such loaders, so we should just drop such classes from the cache.

Some minor suggestions. Looks good otherwise.

test/lib/jdk/test/lib/cds/SimpleCDSAppTester.java line 55:

> 53:     private String name;
> 54:     private BiConsumer<OutputAnalyzer,RunMode> assemblyChecker;
> 55:     private BiConsumer<OutputAnalyzer,RunMode> productionChecker;

Suggestion:

    private BiConsumer<OutputAnalyzer, RunMode> assemblyChecker;
    private BiConsumer<OutputAnalyzer, RunMode> productionChecker;

test/lib/jdk/test/lib/cds/SimpleCDSAppTester.java line 103:

> 101:     }
> 102: 
> 103:     public SimpleCDSAppTester setAssemblyChecker(BiConsumer<OutputAnalyzer,RunMode> checker) {

Suggestion:

    public SimpleCDSAppTester setAssemblyChecker(BiConsumer<OutputAnalyzer, RunMode> checker) {

test/lib/jdk/test/lib/cds/SimpleCDSAppTester.java line 108:

> 106:     }
> 107: 
> 108:     public SimpleCDSAppTester setProductionChecker(BiConsumer<OutputAnalyzer,RunMode> checker) {

Suggestion:

    public SimpleCDSAppTester setProductionChecker(BiConsumer<OutputAnalyzer, RunMode> checker) {

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24710#pullrequestreview-2777052203
PR Review Comment: https://git.openjdk.org/jdk/pull/24710#discussion_r2049715145
PR Review Comment: https://git.openjdk.org/jdk/pull/24710#discussion_r2049715536
PR Review Comment: https://git.openjdk.org/jdk/pull/24710#discussion_r2049715779