RFR: 8354558: -XX:AOTMode=record crashes with boot loader package-info class [v2]

[Ioi Lam]

On Thu, 17 Apr 2025 22:22:10 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @calvinccheung comments
>
> test/lib/jdk/test/lib/cds/SimpleCDSAppTester.java line 55:
> 
>> 53:     private String name;
>> 54:     private BiConsumer<OutputAnalyzer,RunMode> assemblyChecker;
>> 55:     private BiConsumer<OutputAnalyzer,RunMode> productionChecker;
> 
> Suggestion:
> 
>     private BiConsumer<OutputAnalyzer, RunMode> assemblyChecker;
>     private BiConsumer<OutputAnalyzer, RunMode> productionChecker;

Fixed.

> test/lib/jdk/test/lib/cds/SimpleCDSAppTester.java line 103:
> 
>> 101:     }
>> 102: 
>> 103:     public SimpleCDSAppTester setAssemblyChecker(BiConsumer<OutputAnalyzer,RunMode> checker) {
> 
> Suggestion:
> 
>     public SimpleCDSAppTester setAssemblyChecker(BiConsumer<OutputAnalyzer, RunMode> checker) {

Fixed.

> test/lib/jdk/test/lib/cds/SimpleCDSAppTester.java line 108:
> 
>> 106:     }
>> 107: 
>> 108:     public SimpleCDSAppTester setProductionChecker(BiConsumer<OutputAnalyzer,RunMode> checker) {
> 
> Suggestion:
> 
>     public SimpleCDSAppTester setProductionChecker(BiConsumer<OutputAnalyzer, RunMode> checker) {

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24710#discussion_r2049981584
PR Review Comment: https://git.openjdk.org/jdk/pull/24710#discussion_r2049981552
PR Review Comment: https://git.openjdk.org/jdk/pull/24710#discussion_r2049981542