RFR: 8347719: [REDO] Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION [v3]

[Sergey Bylokhov]

On Thu, 24 Apr 2025 11:42:39 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> LGTM, I hope we don't have to back this one out :-).
>
> Thanks for reviews @jdksjolen and @tschatzl

@kimbarrett This introduces another cause for the build failure on Xcode 16.3:
Apple clang version 17.0.0 (clang-1700.0.13.3)
Target: arm64-apple-darwin24.4.0


=== Output from failing command(s) repeated here ===
* For target hotspot_variant-server_libjvm_gtest_objs_test_networkUtilization.o:
In file included fromjdk/test/hotspot/gtest/jfr/test_networkUtilization.cpp:45:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.4.sdk/usr/include/c++/v1/vector:3023:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.4.sdk/usr/include/c++/v1/locale:293:67: error: 'free' is deprecated: use os::free [-Werror,-Wdeprecated-declarations]
  293 |   unique_ptr<unsigned char, void (*)(void*)> __stat_hold(nullptr, free);
      |                                                                   ^
jdk/src/hotspot/share/utilities/forbiddenFunctions.hpp:73:1: note: 'free' has been explicitly marked deprecated here
   73 | FORBID_IMPORTED_C_FUNCTION(void free(void *ptr), "use os::free");
      | ^
jdk/src/hotspot/share/utilities/compilerWarnings.hpp:124:3: note: expanded from macro 'FORBID_IMPORTED_C_FUNCTION'
  124 |   FORBID_C_FUNCTION(FORBIDDEN_FUNCTION_IMPORT_SPEC Signature, Alternative)
      |   ^
jdk/src/hotspot/share/utilities/compilerWarnings.hpp:109:18: note: expanded from macro 'FORBID_C_FUNCTION'
  109 |   extern "C" { [[deprecated(Alternative)]] Signature; }
      |                  ^
In file included from jdk/test/hotspot/gtest/jfr/test_networkUtilization.cpp:45:
   ... (rest of output omitted)

* All command lines available in jdk/build/macosx-aarch64-server-release/make-support/failure-logs.
=== End of repeated output ===

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24608#issuecomment-2833849941