RFR: 8364819: Post-integration cleanups for JDK-8359820 [v3]
Anton Artemov
duke at openjdk.org
Wed Aug 6 14:21:04 UTC 2025
On Wed, 6 Aug 2025 14:11:22 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8364819: Made handling of timed out thread safe
>
> src/hotspot/share/utilities/vmError.hpp line 229:
>
>> 227: static void set_safepoint_timed_out_thread(Thread* thread);
>> 228: static volatile Thread* get_handshake_timed_out_thread();
>> 229: static volatile Thread* get_safepoint_timed_out_thread();
>
> `static volatile` for method declarations makes no real sense? Just `static` would suffice.
If the variable is declared volatile, the same should be done with the getter, otherwise GCC complains about conversion:
error: invalid conversion from 'volatile Thread*' to 'Thread*'
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26656#discussion_r2257345662
More information about the hotspot-dev
mailing list