RFR: 8308094: Add a compilation timeout flag to catch long running compilations [v8]
Dean Long
dlong at openjdk.org
Mon Aug 18 21:43:47 UTC 2025
On Mon, 18 Aug 2025 07:57:43 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:
>> I'm not entirely sure but I guess it's fine since it's in the same thread.
>
> Maybe @dean-long can shed some light on this?
I'm not an expert on resource areas, but using them in a signal handler seems questionable to me. See also JDK-8349578. I don't even think malloc allocations are safe in a signal handler. But since we are crashing, it probably doesn't matter. In this case, I would either add the ResourceMark (too avoid a "missing ResourceMark" assert), or use an alternative method for printing the name and signature. Note that the hs_err log file should contain the name of the method being compiled, so having it here in this assert is useful but not critical.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26023#discussion_r2283559577
More information about the hotspot-dev
mailing list