RFR: 8308094: Add a compilation timeout flag to catch long running compilations [v8]
Manuel Hässig
mhaessig at openjdk.org
Tue Aug 19 14:36:05 UTC 2025
On Mon, 18 Aug 2025 21:41:11 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Maybe @dean-long can shed some light on this?
>
> I'm not an expert on resource areas, but using them in a signal handler seems questionable to me. See also JDK-8349578. I don't even think malloc allocations are safe in a signal handler. But since we are crashing, it probably doesn't matter. In this case, I would either add the ResourceMark (too avoid a "missing ResourceMark" assert), or use an alternative method for printing the name and signature. Note that the hs_err log file should contain the name of the method being compiled, so having it here in this assert is useful but not critical.
I just realized that `name_and_sig_as_C_string()` can also take a buffer and size as argument and will use that with a static buffer instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26023#discussion_r2285474664
More information about the hotspot-dev
mailing list