RFR: 8357086: os::xxx functions returning memory size should return size_t [v33]

[Stefan Karlsson]

On Thu, 21 Aug 2025 12:59:59 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/os/windows/os_windows.cpp line 869:
>> 
>>> 867:     return true;
>>> 868:   } else {
>>> 869:     assert(false, "GlobalMemoryStatusEx failed in os::available_memory(): %lu", ::GetLastError());
>> 
>> I didn't request this to be changed and it was changed to the wrong function name.
>> 
>> Suggestion:
>> 
>>     assert(false, "GlobalMemoryStatusEx failed in os::win32::available_memory(): %lu", ::GetLastError());
>> 
>> 
>> Tip: you can accept suggestions in the GitHub UI to get exactly what the reviewer requested (if you are brave enough to trust the reviewer :D )
>
> Yes, this is really convenient but you have to remember to pull back to your local repo if you want to make additional changes.

Yes and git will remind you about that if you try to push without doing so.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25450#discussion_r2291021344