RFR: 8342769: HotSpot Windows/gcc port is broken [v17]
Julian Waters
jwaters at openjdk.org
Thu Dec 11 04:16:35 UTC 2025
On Tue, 11 Nov 2025 13:01:23 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> Several areas in HotSpot are broken in the gcc port. These, with the exception of 1 rather big oversight within SharedRuntime::frem and SharedRuntime::drem, are all minor correctness issues within the code. These mostly can be fixed with simple changes to the code. Note that I am not sure whether the SharedRuntime::frem and SharedRuntime::drem fix is correct. It may be that they can be removed entirely
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 30 commits:
>
> - Merge branch 'master' into hotspot
> - CAST_FROM_FN_PTR in os_windows.cpp
> - Merge branch 'master' into hotspot
> - Merge branch 'openjdk:master' into hotspot
> - _WINDOWS && AARCH64 in sharedRuntime.hpp
> - AARCH64 in sharedRuntimeRem.cpp
> - Refactor sharedRuntime.cpp
> - CAST_FROM_FN_PTR in os_windows.cpp
> - Merge branch 'openjdk:master' into hotspot
> - fmod_winarm64 in sharedRuntime.cpp
> - ... and 20 more: https://git.openjdk.org/jdk/compare/29100320...b93febb3
Note for anyone looking in: I'm intentionally not progressing this change until the broken fmod in the Visual Studio library is fixed, so we can avoid pushing the workaround in, which I'm not very fond of in the first place.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21627#issuecomment-3640007841
More information about the hotspot-dev
mailing list