RFR: 8342769: HotSpot Windows/gcc port is broken [v17]
Julian Waters
jwaters at openjdk.org
Thu Dec 11 04:16:36 UTC 2025
On Wed, 12 Nov 2025 02:32:53 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> > > Some of these disparate changes are things I would approve of if they were offered separately. Others I think need more work.
> > > For example, for the sharedRuntime changes, is the fmod of infinity issue with Windows, or is it with Visual Studio. If the latter, the conditionalization of the workaround is wrong. Also, has a bug been filed with Microsoft for this? Or has it perhaps already been fixed in some version?
> > > Also, there are comments using "ARM64" but we use "AARCH64" in code.
> >
> >
> > @swesonga filed a bug for this, not sure if this is what you're referring to? https://developercommunity.visualstudio.com/t/fmod-incorrectly-returns-NaN-on-certain-/10793176
>
> Yes, that's what I was looking for. Thanks for the pointer.
>
> > I think this might be an issue with Visual Studio rather than Windows itself. Admittedly I really don't like all the conditionals either, and am hoping for it to be fixed in VS soon so I can delete the workaround entirely, but there hasn't been any news on whether this has been fixed yet or not.
>
> Does gcc on Windows have the same problem? I'm guessing not. This seems almost certainly to be a VS problem, either with the generated code or (more likely) with a runtime support function. Of course, with that in mind we can't remove the workaround until we've moved the minimum supported version forward past the bug fix. That might be a while.
Sorry for not seeing this earlier. I don't believe gcc suffers from the same issue, though for now I cannot test it since gcc is currently broken due to a bug in its codeview debugging internals that still hasn't being fixed yet :(
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21627#issuecomment-3640013289
More information about the hotspot-dev
mailing list