RFR: 8373599: Cleanup arguments.hpp includes [v2]

[Ioi Lam]

On Fri, 12 Dec 2025 15:06:39 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> In the Valhalla project we are considering using a property in Arguments to figure out if Valhalla is enabled. To minimize transitive-include-proliferation if this property ever needs to be checked in a header I propose that we clean up the header includes in arguments.hpp.
>> 
>> I'm opening the review for this so that I can get opinions on the move of functions. I'm going to compile this on all our platforms and will likely add a few more includes when unrelated files fail to compile because they relied on the includes provided through by java.hpp and arguments.hpp.
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Sort order

I think this clean up is good by itself.

However, do you plan to include arguments.hpp in a lot of files (including files) just to check if valhalla is enabled?

If that's the case, I think it's better to move the check into its own header, similar to existing files like cdsConfig.hpp and gcConfig.hpp.  Maybe valueTypeConfig.hpp?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28791#issuecomment-3647181924