RFR: 8373599: Cleanup arguments.hpp includes [v2]
Stefan Karlsson
stefank at openjdk.org
Fri Dec 12 16:24:53 UTC 2025
On Fri, 12 Dec 2025 16:03:26 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> I think this clean up is good by itself.
>
> However, do you plan to include arguments.hpp in a lot of files (including files) just to check if valhalla is enabled?
>
> If that's the case, I think it's better to move the check into its own header, similar to existing files like cdsConfig.hpp and gcConfig.hpp. Maybe valueTypeConfig.hpp?
That would also be fine by me. Maybe we can bring that question over to the Valhalla PR:
https://github.com/openjdk/valhalla/pull/1759
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28791#issuecomment-3647251974
More information about the hotspot-dev
mailing list