RFR: 8373654: Tests in sources/ should only run once [v2]

[Aleksey Shipilev]

On Mon, 15 Dec 2025 21:22:18 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> This test is checking for backsliding on the use of NULL in the hotspot source files. The test only needs to be run once per change but it is defined as a regular tier1 test which then gets run for each os-arch combination, plus product and debug, and then again with a bunch of flags in tier3. This is just a waste of resources. At a minimum we should make the test flagless so that it doesn't run in tier3, but we can also restrict it to a single platform.
>> 
>> Before the change the test ran 27 times in tier1-3 in our CI. After it runs once. 
>> 
>> 
>> EDIT: Updated to include both tests in sources/
>> 
>> Thanks
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Relax platform restriction
>   Add TestIncludesAreSorted

Looks reasonable to me, with only stylistic nits.

test/hotspot/jtreg/sources/TestIncludesAreSorted.java line 28:

> 26:  * @bug 8343802
> 27:  * @comment Only need to run this once, in tier1.
> 28:  * @requires vm.flagless & vm.debug == true

Would that also work?

Suggestion:

 * @comment Only need to run this once, in tier1
 * @requires vm.flagless & vm.debug

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28818#pullrequestreview-3582036511
PR Review Comment: https://git.openjdk.org/jdk/pull/28818#discussion_r2622398643