RFR: 8373654: Tests in sources/ should only run once [v2]
David Holmes
dholmes at openjdk.org
Tue Dec 16 11:44:54 UTC 2025
On Tue, 16 Dec 2025 09:02:20 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Relax platform restriction
>> Add TestIncludesAreSorted
>
> test/hotspot/jtreg/sources/TestIncludesAreSorted.java line 28:
>
>> 26: * @bug 8343802
>> 27: * @comment Only need to run this once, in tier1.
>> 28: * @requires vm.flagless & vm.debug == true
>
> Would that also work?
>
> Suggestion:
>
> * @comment Only need to run this once, in tier1
> * @requires vm.flagless & vm.debug
Probably - certainly a number of tests have it, though the vast majority have explicit checks against true/false. For consistency I will try it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28818#discussion_r2622935270
More information about the hotspot-dev
mailing list