RFR: 8372348: Adjust some UL / JFR string deduplication output messages [v2]
Francesco Andreuzzi
fandreuzzi at openjdk.org
Wed Dec 17 09:01:40 UTC 2025
On Mon, 15 Dec 2025 14:59:46 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> There is some UL output in the string deduplication code that is not very clear and has room for improvement.
>> The inspected strings number should be shown and the new unknown strings get a changed text.
>> (also the new JFR strip dedup event description is slightly adjusted)
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> Enhance output
src/hotspot/share/gc/shared/stringdedup/stringDedupStat.cpp line 107:
> 105: last_stat->_deduped, STRDEDUP_BYTES_PARAM(last_stat->_deduped_bytes),
> 106: percent_of(total_stat->_deduped_bytes, total_stat->_new_bytes),
> 107: total_stat->_deduped_bytes, total_stat->_new_bytes,
Shouldn't these two use `STRDEDUP_BYTES_FORMAT` and `STRDEDUP_BYTES_PARAM`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28455#discussion_r2626160489
More information about the hotspot-dev
mailing list