RFR: 8372348: Adjust some UL / JFR string deduplication output messages [v2]

Matthias Baesken mbaesken at openjdk.org
Wed Dec 17 14:12:33 UTC 2025


On Wed, 17 Dec 2025 08:58:15 GMT, Francesco Andreuzzi <fandreuzzi at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Enhance output
>
> src/hotspot/share/gc/shared/stringdedup/stringDedupStat.cpp line 107:
> 
>> 105:     last_stat->_deduped, STRDEDUP_BYTES_PARAM(last_stat->_deduped_bytes),
>> 106:     percent_of(total_stat->_deduped_bytes, total_stat->_new_bytes),
>> 107:     total_stat->_deduped_bytes, total_stat->_new_bytes,
> 
> Shouldn't these two use `STRDEDUP_BYTES_FORMAT` and `STRDEDUP_BYTES_PARAM`?

Yeah seems so,  this is what is used for `  STRDEDUP_BYTES_PARAM(last_stat->_new_bytes), STRDEDUP_BYTES_PARAM(last_stat->_deduped_bytes),`  .

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28455#discussion_r2627221140


More information about the hotspot-dev mailing list