RFR: 8348349: Refactor CDSConfig::is_dumping_heap() [v3]
Ioi Lam
iklam at openjdk.org
Tue Feb 4 05:48:29 UTC 2025
> Please review this small clean up:
>
> `HeapShared::can_write()` and `CDSConfig::is_dumping_heap()` are both for deciding whether CDS should dump heap objects. I removed the former and consolidated all the logic to the latter.
>
> I also updated the logging message in case heap objects cannot be dumped.
>
> I also updated VMProps to clarify what `vmCDSCanWriteArchivedJavaHeap()` means.
Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
- Merge branch 'master' into 8348349-refactor-heap-shared-can-write
- @matias9927 comment
- Fixed whitespace
- Fixed 32-bit build
- 8348349: Refactor HeapShared::can_write()
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23249/files
- new: https://git.openjdk.org/jdk/pull/23249/files/a6a77ca7..846e99cb
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23249&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23249&range=01-02
Stats: 29621 lines in 1223 files changed: 14643 ins; 7811 del; 7167 mod
Patch: https://git.openjdk.org/jdk/pull/23249.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23249/head:pull/23249
PR: https://git.openjdk.org/jdk/pull/23249
More information about the hotspot-dev
mailing list