RFR: 8343802: Prevent NULL usage backsliding [v2]

[Chen Liang]

On Wed, 5 Feb 2025 19:05:24 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update based on feedback
>
> test/hotspot/jtreg/sources/TestNoNULL.java line 103:
> 
>> 101:             public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) {
>> 102:                 if (isIncluded(file, excludedFiles, excludeExtensions)) {
>> 103:                     files.add(file);
> 
> Why collect files to be checked, rather than just checking them here?

I agree with @kimbarrett; there is no point creating buffer collections that consume more resources with no real gains.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23466#discussion_r1944101310