RFR: 8343802: Prevent NULL usage backsliding [v2]

Johan Sjölen jsjolen at openjdk.org
Thu Feb 6 18:36:21 UTC 2025


On Wed, 5 Feb 2025 18:49:07 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update based on feedback
>
> test/hotspot/jtreg/sources/TestNoNULL.java line 135:
> 
>> 133:     private static boolean checkForNull(Path path) throws IOException {
>> 134:         boolean found = false;
>> 135:         List<String> lines = Files.readAllLines(path, StandardCharsets.UTF_8);
> 
> I would have thought it would be better to read and check a line at a time.  Though it probably doesn't really
> matter all that much.

We've got human-sized source files, I think this is fine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23466#discussion_r1945237725


More information about the hotspot-dev mailing list