RFR: 8343802: Prevent NULL usage backsliding [v2]
Nizar Benalla
nbenalla at openjdk.org
Thu Feb 6 12:07:15 UTC 2025
On Thu, 6 Feb 2025 05:07:24 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update based on feedback
>
> test/hotspot/jtreg/sources/TestNoNULL.java line 56:
>
>> 54: }
>> 55:
>> 56: if (dir == null) {
>
> @sormuras Do you know if the source directory (or directories) of the JDK is passed to jtreg at all? The current approach seems a bit hacky.
Copy-pasting this comment from the JBS issue
> We have the full source available when jtreg tests are run in our internal systems. The same should be true in GHA, as well as when developers run tests locally.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23466#discussion_r1944606963
More information about the hotspot-dev
mailing list