RFR: 8343802: Prevent NULL usage backsliding [v2]

[Chen Liang]

On Thu, 6 Feb 2025 12:04:02 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> test/hotspot/jtreg/sources/TestNoNULL.java line 56:
>> 
>>> 54:         }
>>> 55: 
>>> 56:         if (dir == null) {
>> 
>> @sormuras Do you know if the source directory (or directories) of the JDK is passed to jtreg at all? The current approach seems a bit hacky.
>
> Copy-pasting this comment from the JBS issue
> 
>> We have the full source available when jtreg tests are run in our internal systems. The same should be true in GHA, as well as when developers run tests locally.

That doesn't imply the current approach is the best approach to access the source; it only states that the access is *possible*.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23466#discussion_r1947074333