RFR: 8337217: Port VirtualMemoryTracker to use VMATree [v30]
Gerard Ziemski
gziemski at openjdk.org
Mon Feb 24 21:20:13 UTC 2025
On Mon, 14 Oct 2024 08:52:50 GMT, Afshin Zafari <azafari at openjdk.org> wrote:
>> src/hotspot/share/nmt/memReporter.cpp line 442:
>>
>>> 440: if (all_committed) {
>>> 441: bool reserved_and_committed = false;
>>> 442: VirtualMemoryTracker::Instance::tree()->visit_committed_regions(*reserved_rgn,
>>
>> Change the signature of `visit_committed_regions` to taking `(position start, size size)` instead of the `ReservedMemoryRegion`.
>
> Done.
2 questions:
1st, I must be misunderstanding something here. Johan asked to change the API from:
`visit_committed_regions(ReservedMemoryRegion& committed_rgn)`
to
`visit_committed_regions(position start, size size)`
but I still see the old way.
2nd, why are we asking for this change?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1968128713
More information about the hotspot-dev
mailing list