RFR: 8337217: Port VirtualMemoryTracker to use VMATree [v32]

Afshin Zafari azafari at openjdk.org
Fri Feb 28 13:12:17 UTC 2025


On Thu, 27 Feb 2025 18:11:26 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed UseFlagInPlace test.
>
> src/hotspot/share/nmt/virtualMemoryTracker.cpp line 225:
> 
>> 223: 
>> 224: int compare_reserved_region_base(const ReservedMemoryRegion& r1, const ReservedMemoryRegion& r2) {
>> 225:   return r1.compare(r2);
> 
> Why did we name it `compare_reserved_region_base`, not simply `compare_reserved_region`

This function and also `compare_committed_region` are used as comparators for `SortedLinkedList` and have no use anymore here. They are removed.
Thanks for catching this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1975387868


More information about the hotspot-dev mailing list