RFR: 8337217: Port VirtualMemoryTracker to use VMATree [v32]
Afshin Zafari
azafari at openjdk.org
Fri Feb 28 13:26:12 UTC 2025
On Thu, 27 Feb 2025 18:06:50 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>>
>> removed UseFlagInPlace test.
>
> src/hotspot/share/nmt/virtualMemoryTracker.cpp line 114:
>
>> 112: committed = VirtualMemorySummary::as_snapshot()->by_type(tag)->committed();
>> 113: if (reserve_delta != 0) {
>> 114: if (reserve_delta > 0)
>
> Missing braces.
Done.
> src/hotspot/share/nmt/virtualMemoryTracker.cpp line 118:
>
>> 116: else {
>> 117: if ((size_t)-reserve_delta <= reserved)
>> 118: VirtualMemorySummary::record_released_memory(-reserve_delta, tag);
>
> Missing braces.
Done.
> src/hotspot/share/nmt/virtualMemoryTracker.cpp line 129:
>
>> 127: }
>> 128: else
>> 129: print_err("commit");
>
> Missing braces.
Done.
> src/hotspot/share/nmt/virtualMemoryTracker.cpp line 133:
>
>> 131: else {
>> 132: if ((size_t)-commit_delta <= committed)
>> 133: VirtualMemorySummary::record_uncommitted_memory(-commit_delta, tag);
>
> Missing braces.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1975405233
PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1975400984
PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1975405522
PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1975405745
More information about the hotspot-dev
mailing list