RFR: 8346193: CrashGCForDumpingJavaThread do not trigger expected crash build with clang17 [v5]

[SendaoYan]

On Thu, 2 Jan 2025 02:48:58 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Delete curly braces
>
> src/hotspot/share/runtime/frame.cpp line 1166:
> 
>> 1164:   // simulate GC crash here to dump java thread in error report
>> 1165:   if (CrashGCForDumpingJavaThread)
>> 1166:     guarantee(!CrashGCForDumpingJavaThread, "");
> 
> Besides being contrary to the HotSpot Style Guide, that isn't at all what I
> meant.  We don't need to test CrashGCForDumpingJavaThread before testing it
> again int the guarantee.

Sorry, got it now.
The duplicate `CrashGCForDumpingJavaThread` check has been removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22757#discussion_r1900512597