RFR: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION [v2]

[Kim Barrett]

On Thu, 9 Jan 2025 00:46:51 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Yes, I think it's fine to say !WINDOWS instead of listing all the posix ports.  We've been avoiding dispatch files and once it reaches a threshold of too many #ifdef !WINDOWS #include posix.hpp one, then we could add another macro like the OS_CPU one.
>> 
>> Also the copyright script added 2025 for these because they started with 2024 so it's sort of a bug in the script but not really solvable because it doesn't know that you didn't check this in in 2024.
>
>> It seems to me that breaking the abstraction like that is just asking for trouble.
> 
> Sorry but what "abstraction" are you referring to?

@dholmes-ora - OS_HEADER and CPU_HEADER instead of explicit knowledge of what platforms exist and
which ones share some code in a "_posix" file and which ones have some unshared code.  IMO the includer
shouldn't need to know that kind of implementation detail.

But oh well, all y'all seem to really hate the simple forwarding files and would prefer to skip that in favor of
hard-coding the file organization.  In the interest of making progress, I'll do that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22890#discussion_r1908229538