RFR: 8347981: RISC-V: Add Zfa zli imm loads [v2]

Fei Yang fyang at openjdk.org
Tue Jan 21 02:39:39 UTC 2025


On Sat, 18 Jan 2025 08:43:10 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 2634:
>> 
>>> 2632:   }
>>> 2633:   int Rs = -1;
>>> 2634:   can_zfa_zli_float(imm, &Rs);
>> 
>> should that be a `guarantee(can_zfa_zli_float(imm, &Rs));`?
>
> Same, my bad. (guarantee in zli_s on that Rs is uimm5.)
> 
> As we already an guarantee, maybe assert(can_zfa..) ?

How about we do this directly on the callsite?

  int Rs = -1;
  if (can_zfa_zli_float(imm, &Rs)) {
    _fli_s(Rd, Rs);
  }

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23171#discussion_r1922990549


More information about the hotspot-dev mailing list