RFR: 8347981: RISC-V: Add Zfa zli imm loads [v2]

Robbin Ehn rehn at openjdk.org
Sat Jan 18 20:02:36 UTC 2025


On Sat, 18 Jan 2025 13:04:34 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Sorry my bad for not adding a comment.
>> I'm using the guarantee in zli_d on that Rs is uimm5.
>> 
>> As we already an guarantee, maybe assert(can_zfa..) ?
>
> `assert(can_zfa..)` are not compiled in on release builds. You could then have `bool ret = can_zfa_zli_double(imm, &Rs); assert(ret);`

Yes, thanks. Easy to forget about :)

`assert(Rs != -1, "Invalid zli lookup");`

Is also an alternative. What you think?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23171#discussion_r1921142359


More information about the hotspot-dev mailing list