RFR: 8344232: [PPC64] secondary_super_cache does not scale well: C1 and interpreter [v2]

Martin Doerr mdoerr at openjdk.org
Thu Jan 23 14:07:29 UTC 2025


On Thu, 23 Jan 2025 13:49:34 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove early return from check_klass_subtype_slow_path.
>
> src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 2158:
> 
>> 2156:   std(super_klass, target_offset, sub_klass); // save result to cache
>> 2157:   if (result_reg != noreg) { li(result_reg, 0); } // load zero result (indicates a hit)
>> 2158:   if (L_success != nullptr) { b(*L_success); }
> 
> Handling `L_success != nullptr` should be put on the else-branch of the previous if-statement.

Doesn't make a real difference, but I've cleaned it up.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22881#discussion_r1927032384


More information about the hotspot-dev mailing list