RFR: 8348349: Refactor CDSConfig::is_dumping_heap() [v2]

[Calvin Cheung]

On Mon, 27 Jan 2025 05:51:58 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Please review this small clean up:
>> 
>> `HeapShared::can_write()` and `CDSConfig::is_dumping_heap()` are both for deciding whether CDS should dump heap objects. I removed the former and consolidated all the logic to the latter.
>> 
>> I also updated the logging message in case heap objects cannot be dumped.
>> 
>> I also updated VMProps to clarify what `vmCDSCanWriteArchivedJavaHeap()` means.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @matias9927 comment

LGTM

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23249#pullrequestreview-2581823665