RFR: 8349003: NativeCallStack::print_on() output is unreadable
David Holmes
dholmes at openjdk.org
Thu Jan 30 06:38:45 UTC 2025
On Wed, 29 Jan 2025 22:00:08 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:
> Please review this trivial change that improves output readability.
Marked as reviewed by dholmes (Reviewer).
src/hotspot/share/utilities/nativeCallStack.cpp line 118:
> 116: out->cr();
> 117: }
> 118: out->cr();
Do you need the `cr()` after the loop now? Guess it is a matter of personal preference depending on the context in which this gets printed.
-------------
PR Review: https://git.openjdk.org/jdk/pull/23359#pullrequestreview-2583029495
PR Review Comment: https://git.openjdk.org/jdk/pull/23359#discussion_r1935077246
More information about the hotspot-dev
mailing list