RFR: 8349003: NativeCallStack::print_on() output is unreadable [v2]

Zhengyu Gu zgu at openjdk.org
Thu Jan 30 14:15:33 UTC 2025


On Thu, 30 Jan 2025 06:35:15 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   David's comment
>
> src/hotspot/share/utilities/nativeCallStack.cpp line 118:
> 
>> 116:     out->cr();
>> 117:   }
>> 118:   out->cr();
> 
> Do you need the `cr()` after the loop now? Guess it is a matter of personal preference depending on the context in which this gets printed.

Good point. Let's restore to pre [JDK-8333994](https://bugs.openjdk.org/browse/JDK-8333994) behavior, where it does not have `cr()` after the loop.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23359#discussion_r1935678731


More information about the hotspot-dev mailing list