RFR: 8363584: Sort share/utilities includes [v4]

Francesco Andreuzzi duke at openjdk.org
Fri Jul 25 08:49:12 UTC 2025


On Thu, 24 Jul 2025 22:55:01 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more sorting
>
> src/hotspot/share/utilities/vmError.cpp line 41:
> 
>> 39: #if INCLUDE_JVMCI
>> 40: #include "jvmci/jvmci.hpp"
>> 41: #endif
> 
> These changes shouldn't be made.  Conditional includes go at the end.

Noted, reverted in a27bef538f1b5cb3465e247798319a2d4a463102

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26428#discussion_r2230537371


More information about the hotspot-dev mailing list