RFR: 8362564: hotspot/jtreg/compiler/c2/TestLWLockingCodeGen.java fails on static JDK on x86_64 with AVX instruction extensions [v2]

Chuck Rasbold rasbold at openjdk.org
Fri Jul 25 17:58:53 UTC 2025


On Fri, 25 Jul 2025 17:39:47 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> If you need information which is printed out in the log, why not to add needed information to the assert? You can copy the format string used for logging. This will make assert's output more informative without a need for enabling logging.
>
> Sounds reasonable to me. I updated the PR to move back the assert and added code_size, buffer total size and free size info to the assert output. Thanks

I actually think the change is better with the assert after the logging, as initially proposed. 

I don't object to the making the assert's output more informative, but can imagine that there may be future improvements to the log message which may then leave the assert with a different message.

The risk of switching the assertion and logging seems minimal.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26395#discussion_r2231716799


More information about the hotspot-dev mailing list