RFR: 8362564: hotspot/jtreg/compiler/c2/TestLWLockingCodeGen.java fails on static JDK on x86_64 with AVX instruction extensions [v2]

[Jiangli Zhou]

On Fri, 25 Jul 2025 17:56:28 GMT, Chuck Rasbold <rasbold at openjdk.org> wrote:

>> Sounds reasonable to me. I updated the PR to move back the assert and added code_size, buffer total size and free size info to the assert output. Thanks
>
> I actually think the change is better with the assert after the logging, as initially proposed. 
> 
> I don't object to the making the assert's output more informative, but can imagine that there may be future improvements to the log message which may then leave the assert with a different message.
> 
> The risk of switching the assertion and logging seems minimal.

@rasbold Thanks for the thought! Right, there doesn't seem to be much risk with moving the assert to after the logging. With the additional info in the assert output as @eastig suggested, it does provide enough information without needing to enable `-Xlog:stubs`. In the case where we ran into the particular problem in non-local testing environment, the additional size information provided in the assert could save quite some debugging time. So the current change does seem to be a bit more advantageous.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26395#discussion_r2231808594