RFR: 8364169: (NMT) Move nativeCallStack to nmt

Thu Jul 31 08:05:55 UTC 2025

On Mon, 28 Jul 2025 08:37:58 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Trivial file move of NativeCallStack to the `nmt` sub directory.

I feel the name `NativeCallStack` is general enough so it might not be necessarily related to NMT.

Also looked a bit inside `NativeCallStack`, but it's unclear to me why the stack-depth is nmt-constant. Why can't a user of `NativeCallStack` (e.g. `CompilationFailureInfo` ) specify the desired stack-depth? Is there an invariant that stack-depth must be a global-constant?

src/hotspot/share/jfr/utilities/jfrAllocation.cpp line 30:

> 28: #include "memory/allocation.inline.hpp"
> 29: #include "nmt/memTracker.hpp"
> 30: #include "nmt/nativeCallStack.hpp"

I can't find out why this include is actually used inside this file.

-------------

PR Review: https://git.openjdk.org/jdk/pull/26498#pullrequestreview-3074358490
PR Review Comment: https://git.openjdk.org/jdk/pull/26498#discussion_r2244636520