RFR: 8364169: (NMT) Move nativeCallStack to nmt

Thomas Stuefe stuefe at openjdk.org
Thu Jul 31 08:18:00 UTC 2025


On Thu, 31 Jul 2025 08:03:35 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> I feel the name `NativeCallStack` is general enough so it might not be necessarily related to NMT.
> 

Okay, I will withdraw this change. It was always very tightly interwoven with NMT. Maybe decoupling that is the better option.

> Also looked a bit inside `NativeCallStack`, but it's unclear to me why the stack-depth is nmt-constant. Why can't a user of `NativeCallStack` (e.g. `CompilationFailureInfo` ) specify the desired stack-depth? Is there an invariant that stack-depth must be a global-constant?

No, apart from its just not done this way (frames are inlined). 
I plan to address this shortly (https://bugs.openjdk.org/browse/JDK-8318174) . In fact, this PR was supposed to be the preparation for that change, but I can do things differently than I had planned originally.

Closing this after reconsideration and after @albertnetymk feedback

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26498#issuecomment-3138984563
PR Comment: https://git.openjdk.org/jdk/pull/26498#issuecomment-3138986019


More information about the hotspot-dev mailing list