RFR: 8337666: AArch64: SHA3 GPR intrinsic [v4]
Dmitry Chuyko
dchuyko at openjdk.org
Tue Jun 3 17:09:57 UTC 2025
On Tue, 3 Jun 2025 14:22:10 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp line 331:
>>
>>> 329:
>>> 330: inline void rol(Register Rd, Register Rn, unsigned imm) {
>>> 331: extr(Rd, Rn, Rn, ((64 - imm) & 63));
>>
>> Suggestion:
>>
>> extr(Rd, Rn, Rn, (64 - imm));
>>
>> It's better to catch an out-of-range immediate value.
>
> `rolw` too.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24260#discussion_r2124451203
More information about the hotspot-dev
mailing list