RFR: 8357396: Refactor nmethod::make_not_entrant to use Enum instead of "const char*" [v4]

[Aleksey Shipilev]

On Tue, 3 Jun 2025 18:52:34 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> Please review this refactor to transform the reasons for making an nmethod not entrant from `const char*` into enum values.
>> 
>> Tested on Linux x64 with JTREG tier1-3 in fastdebug and release mode.
>
> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix spacing, fix build.

src/hotspot/share/code/nmethod.cpp line 1971:

> 1969:     if (xtty != nullptr) {
> 1970:       ttyLocker ttyl;  // keep the following output all in one block
> 1971:       xtty->begin_elem("make_not_entrant thread='%zu' change_reason='%s'",

Wait, let's not change the actual key here. This is part of XML logging, AFAICS, so this might break some tools.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25338#discussion_r2124657484