RFR: 8357396: Refactor nmethod::make_not_entrant to use Enum instead of "const char*" [v4]

[Cesar Soares Lucas]

On Tue, 3 Jun 2025 18:47:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix spacing, fix build.
>
> src/hotspot/share/code/nmethod.cpp line 1971:
> 
>> 1969:     if (xtty != nullptr) {
>> 1970:       ttyLocker ttyl;  // keep the following output all in one block
>> 1971:       xtty->begin_elem("make_not_entrant thread='%zu' change_reason='%s'",
> 
> Wait, let's not change the actual key here. This is part of XML logging, AFAICS, so this might break some tools.

Sure, I'll revert that. I thought it would be "fine" to change the key here since it was added not "long ago.."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25338#discussion_r2124736640